Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used
taskId
as a way to link atask
with it's result stored in localStorage.However,
taskId
was essentially anindex
value and we could only ever add new tasks to the end of existing ones. This PR moves over to using thetask.name
as the unique key.Pros:
Cons:
I think on balance using the task.name is the better path for now. We could look at doing something more sophisticated in the future if we need to